Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmarker API #1259

Merged
merged 13 commits into from
Sep 27, 2023
Merged

benchmarker API #1259

merged 13 commits into from
Sep 27, 2023

Conversation

horheynm
Copy link
Member

@horheynm horheynm commented Sep 20, 2023

Trigger
deepsparse.benchmark
deepsparse.benchmark_pipeline

Example code in tests

Copy link
Member

@bfineran bfineran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall - need a way to instantiate model and pipeline from other sources (ie files, kwargs, etc)

src/deepsparse/benchmark/api/benchmarker.py Outdated Show resolved Hide resolved
@horheynm horheynm changed the title benchmarker benchmarker API Sep 25, 2023
@horheynm horheynm marked this pull request as ready for review September 25, 2023 19:39
Copy link
Member

@bfineran bfineran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall - the only thing I think would be missing is a way to pass an already instantiated pipeline object to benchmarker

something like:

my_pipeline = Pipeline.create(...)

benchmarker = Benchmarker(pipeline=my_pipeline)

src/deepsparse/benchmark/api/benchmarker.py Outdated Show resolved Hide resolved
src/deepsparse/benchmark/api/benchmarker.py Outdated Show resolved Hide resolved
@bfineran bfineran merged commit 52fac4b into main Sep 27, 2023
13 checks passed
@bfineran bfineran deleted the benchmarker branch September 27, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants