[Text Generation][KVCacheStorage] TextGenerationPipeline refactor
#1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ralmagic/deepsparse into feature/damian/chat_pipeline
dbogunowicz
commented
Sep 20, 2023
| @@ -670,6 +654,9 @@ def engine_forward( | |||
| if streamer is not None: | |||
| streamer.end() | |||
|
|
|||
| if self._debug: | |||
| self._debug = dict(kv_cache=session) | |||
There was a problem hiding this comment.
purely for testing purposes
There was a problem hiding this comment.
even for debug we won't want to update state at runtime, we should attach this to the returned output schema if possible (does not need to be part of the schema)
dbogunowicz
changed the title
TextGenerationPipeline refactor
rahul-tuli
reviewed
Sep 20, 2023
bfineran
reviewed
Sep 20, 2023
| @@ -670,6 +654,9 @@ def engine_forward( | |||
| if streamer is not None: | |||
| streamer.end() | |||
|
|
|||
| if self._debug: | |||
| self._debug = dict(kv_cache=session) | |||
There was a problem hiding this comment.
even for debug we won't want to update state at runtime, we should attach this to the returned output schema if possible (does not need to be part of the schema)
Satrat
reviewed
Sep 21, 2023
Satrat
approved these changes
Sep 21, 2023
|
failures look unrelated - merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As agreed with the team, the old design for
KVCacheSessionStoragewas ugly, given the series of recent refactors.The goal of this PR is to decouple the
DecoderKVCachefrom theNLDecoderEngine. This will allow us to implement the upcomingChatPipeline(TextGenerationPipeline)much more cleanly.This is roughly the design envisioned:
Testing:
test_text_generation.py