-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add session context manager for Chat pipeline #1239
Closed
rahul-tuli
wants to merge
10
commits into
feature/damian/storage
from
kv-cache-session-context-manager
Closed
Add session context manager for Chat pipeline #1239
rahul-tuli
wants to merge
10
commits into
feature/damian/storage
from
kv-cache-session-context-manager
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfineran
reviewed
Sep 14, 2023
rahul-tuli
commented
Sep 14, 2023
@classmethod | ||
def is_nlp(cls, task: str) -> bool: | ||
""" | ||
:param task: the name of the task to check whether it is an nlp task | ||
such as question_answering | ||
:return: True if it is an nlp task, False otherwise | ||
""" | ||
return any([nlp_task.matches(task) for nlp_task in cls.nlp]) | ||
return any(nlp_task.matches(task) for nlp_task in cls.nlp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These nits should be a part of a separate PR ideally, but added them here as I was already touching this file
Satrat
approved these changes
Sep 15, 2023
closing with #1276 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a session context manager for chat pipelines
Tests: Added automated tests
Local Test:
Output: