Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chatbot demo #1229

Closed

Conversation

dbogunowicz
Copy link
Contributor

No description provided.

@dbogunowicz dbogunowicz changed the base branch from main to feature/damian/storage September 7, 2023 14:33
while True:
# get input from user
input_text = input("User: ")
response = pipeline(sequences=[input_text], session_ids=args.session_id)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the point of having session id as an arg?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, for this small example probably should be a fixed string.

@dbogunowicz
Copy link
Contributor Author

@rahul-tuli my few cents on the design of CLI.
We should allow the user to modify:

  • whether the generation is deterministic or not
  • the temperature of the logits distribution
  • max generated length
  • sequence_length
  • Maybe the parameters introduced in this PR by @horheynm : [TextGeneration] Samling arguments for generation #1225. I do not have yet a good understanding of how to tune them to get the most impressive conversion flow, but it feels like they can be helpful
    Limitations:
  • I'd probably keep it simple. Let's only input one sequence at a time.

Maybe beautifying the interface with some colors in stdout and emoticons (LLaMa2 famously is able to output emojis: abetlen/llama-cpp-python#608)

@dbogunowicz
Copy link
Contributor Author

Closing, as this is now the duplicate of #1235

@dbogunowicz dbogunowicz reopened this Sep 21, 2023
@dbogunowicz dbogunowicz changed the base branch from feature/damian/storage to feature/damian/actual_chat_pipeline September 21, 2023 10:21
@dbogunowicz dbogunowicz force-pushed the feature/damian/actual_chat_pipeline branch 2 times, most recently from 182c7c7 to 660e45a Compare September 22, 2023 07:23
@bfineran
Copy link
Member

out of date - closing

@bfineran bfineran closed this Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants