[Feature Branch][LLM Testing] Create GroundTruthSource objects #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbogunowicz
commented
Aug 30, 2023
…/damian/testing_sources_truth
…/damian/testing_sources_truth
bfineran
reviewed
Sep 5, 2023
Comment on lines
68
to
75
| assert numpy.allclose( | ||
| torch_target_prompt_logits, ort_target_prompt_logits, atol=1e-4 | ||
| ) | ||
| # check that the prompt cache is the same | ||
| for torch_cache, ort_cache in zip( | ||
| torch_target_prompt_cache, ort_target_prompt_cache | ||
| ): | ||
| assert numpy.allclose(torch_cache, ort_cache, atol=1e-5) |
There was a problem hiding this comment.
could be useful to add in this functionality as helper to the GTS objects
| from sparsezoo import Model | ||
|
|
||
|
|
||
| class GroundTruthSource(ABC): |
There was a problem hiding this comment.
let's rename to Source or GenerationSource? we use this for all scenarios, not just ground truth right?
…/damian/testing_sources_truth
* Update README.md * Update src/deepsparse/yolov8/README.md * Update text_generation.py * quality * readability * all tests passing * added some full kv cache tests * initial commit * ready for review * Delete tests/deepsparse/transformers/pipelines/proposal_text_generation_tests.md
…re_branch' into feature/damian/testing_sources_truth
dbogunowicz
added a commit
that referenced
this pull request
Sep 13, 2023
* initial commit * initial commit * [Feature Branch][LLM Testing] Create GroundTruthSource objects (#1219) * initial commit * finish creation of helper objects * Update tests/conftest.py * small refactor * [Feature Branch][LLM Testing] LLM Testing Suite (#1227) * Update README.md * Update src/deepsparse/yolov8/README.md * Update text_generation.py * quality * readability * all tests passing * added some full kv cache tests * initial commit * ready for review * Delete tests/deepsparse/transformers/pipelines/proposal_text_generation_tests.md * fix tests * Dipika's comments plus adjusting the script to renamed variables * remove ORT ground truth * add OPT tests * rebase and disable tests in GHA * quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create two objects that facilitate the generation of the ground truth data (coming from ORT and Torch models) for LLM testing.