Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timing for KV cache update #1196

Merged
merged 3 commits into from
Sep 8, 2023
Merged

Add timing for KV cache update #1196

merged 3 commits into from
Sep 8, 2023

Conversation

dbogunowicz
Copy link
Contributor

@dbogunowicz dbogunowicz commented Aug 23, 2023 •
edited
Loading

Ben's changes that allow for more granular benchmarking of the text generation pipeline.

@bfineran bfineran marked this pull request as ready for review September 6, 2023 14:14
@dbogunowicz dbogunowicz changed the title [WiP] [Ben's work] add timing for KV cache update Add timing for KV cache update Sep 8, 2023
@bfineran
Copy link
Contributor

bfineran commented Sep 8, 2023

errors unrelated, confirmed locally

@bfineran bfineran merged commit d92822f into main Sep 8, 2023
4 of 13 checks passed
@bfineran bfineran deleted the kv-cache-update-improvement branch September 8, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bfineran bfineran bfineran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbogunowicz @bfineran