Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TextGeneration Pipeline] argument renaming #1194

Merged
merged 7 commits into from
Sep 6, 2023
Merged

[TextGeneration Pipeline] argument renaming #1194

merged 7 commits into from
Sep 6, 2023

Conversation

horheynm
Copy link
Member

@horheynm horheynm commented Aug 21, 2023 •
edited
Loading

Rename prompt_processing_sequence_length to prompt_sequence_length
Rename use_deepsparse_cache to internal_kv_cache

@horheynm horheynm marked this pull request as ready for review August 21, 2023 21:18
@dbogunowicz
Copy link
Contributor

Where does this come from?

@horheynm
Copy link
Member Author

Member

https://app.asana.com/0/1200536957474059/1205276886236969

bfineran
bfineran previously approved these changes Aug 31, 2023
View reviewed changes
@bfineran bfineran changed the title renaming [TextGeneration Pipeline] argument renaming Aug 31, 2023
@horheynm horheynm merged commit f53cf3e into main Sep 6, 2023
13 checks passed
@horheynm horheynm deleted the rename-llm-variables branch September 6, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Satrat Satrat Satrat approved these changes

@dbogunowicz dbogunowicz dbogunowicz approved these changes

@bfineran bfineran Awaiting requested review from bfineran

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@horheynm @dbogunowicz @Satrat @bfineran