Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transformers] Add an argument trust_remote_code on transformers pipeline initialization. #1173

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

dbogunowicz
Copy link
Contributor

Give a user an option to enable running remote code through pipeline argument e.g.

Pipeline.create(task="...", trust_remote_code = True)

By default trust_remote_code=False.

Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
Side note: I think there is a problem with discoverability for arguments that are inherited by pipeline. Maybe this would be "solved" by autogenerated docs but I'm not sure how to make it more visible just looking at the constructors

Copy link
Member

@rahul-tuli rahul-tuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! could you update the PR description with an example of what does this option allow a user to do that wasn't possible before?

@Satrat Satrat self-requested a review August 8, 2023 13:26
@dbogunowicz dbogunowicz merged commit c8f6b0e into main Aug 8, 2023
7 checks passed
@dbogunowicz dbogunowicz deleted the feature/damian/trust_remote_code branch August 8, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants