[Text Generation] Causal Mask Feature Branch #1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* initial commit * clean up the PR * working implementation * Ben's review comments
* initial commit * clean up the PR * working implementation * initial implementation, hacky lets clean it up * ready for review * few tiny quality improvements * simplify the logic for computing num of unmasked bits for creating attention_mask for the multitoken prefill
bfineran
previously approved these changes
Jul 25, 2023
bfineran
previously approved these changes
Jul 27, 2023
bfineran
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the feature branch that will aggregate a series of PRs that share a common goal: enable causal mask support in the text generation pipeline for all models that require it.
This PR alone introduces a function that computes a causal mask from the inputs to the model.
Includes
causal_maskinput in the text generation pipeline. Enables runningself.multitoken_enginein a scenario when1 <input_ids_length < sequence_lengthself.multitoken_engineTesting
Refer to the PRs above