Restrict pydantic<2.0.0 due to breaking changes
#1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> Pydantic V2 is a ground-up rewrite that offers many new features, performance improvements, and some breaking changes compared to Pydantic V1.
```
deepsparse/pipeline.py:822: in <module>
class PipelineConfig(BaseModel):
...
NameError: Field "model_path" has conflict with protected namespace "model_"
```
mgoin
requested review from
bfineran,
a team,
natuan and
horheynm
and removed request for
a team
bfineran
approved these changes
Jun 30, 2023
This was referenced Jun 30, 2023
bfineran
pushed a commit
that referenced
this pull request
Jul 5, 2023
> Pydantic V2 is a ground-up rewrite that offers many new features, performance improvements, and some breaking changes compared to Pydantic V1.
```
deepsparse/pipeline.py:822: in <module>
class PipelineConfig(BaseModel):
...
NameError: Field "model_path" has conflict with protected namespace "model_"
```
bfineran
added a commit
that referenced
this pull request
Jul 5, 2023
* Restrict `pydantic<2.0.0` due to breaking changes (#1104) > Pydantic V2 is a ground-up rewrite that offers many new features, performance improvements, and some breaking changes compared to Pydantic V1. ``` deepsparse/pipeline.py:822: in <module> class PipelineConfig(BaseModel): ... NameError: Field "model_path" has conflict with protected namespace "model_" ``` * bump version to 1.5.2 --------- Co-authored-by: Michael Goin <michael@neuralmagic.com>
horheynm
pushed a commit
that referenced
this pull request
Jul 6, 2023
> Pydantic V2 is a ground-up rewrite that offers many new features, performance improvements, and some breaking changes compared to Pydantic V1.
```
deepsparse/pipeline.py:822: in <module>
class PipelineConfig(BaseModel):
...
NameError: Field "model_path" has conflict with protected namespace "model_"
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testing and support for latest pydantic to be added in future release