Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include dylib in search for package contents #1096

Merged
merged 1 commit into from
Jun 27, 2023
Merged

include dylib in search for package contents #1096

merged 1 commit into from
Jun 27, 2023

Conversation

andy-neuma
Copy link
Member

@andy-neuma andy-neuma commented Jun 26, 2023

SUMMARY:
This enables packaging of the "dylib" files into mac "wheel" file. Updates setup.py to include files with extension .dylib and adds src/deepsparse/neon to the manifest via recursive-include.

TEST:

  • verified the "wheel" package is built and installable.

  • looked through "wheel" package contents and verified our magic bits are present.

steve_jobs@wontkins deepsparse % ls neon 
total 366928
drwxr-xr-x   5 steve_jobs  staff        160 Jun 26 15:20 .
drwxr-xr-x  29 steve_jobs  staff        928 Jun 26 15:20 ..
-rwxr-xr-x   1 steve_jobs  staff    1400372 Jun 26  2023 deepsparse_engine.so
-rwxr-xr-x   1 steve_jobs  staff    1195712 Jun 26  2023 libdeepsparse.dylib
-rwxr-xr-x   1 steve_jobs  staff  185267880 Jun 26  2023 libonnxruntime.1.12.0.dylib
  • installed on multiple mac machines and ran simple benchmarks, e.g.
deepsparse.benchmark zoo:nlp/sentiment_analysis/obert-base/pytorch/huggingface/sst2/base-none --batch_size 64

Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, we will also need to update utils/artifacts.py in order to pull down the right dylib artifacts for aarch64

@bfineran
Copy link
Member

test failure appears unrelated, merging

@bfineran bfineran merged commit 58f250c into main Jun 27, 2023
6 of 7 checks passed
@bfineran bfineran deleted the include-dylib branch June 27, 2023 14:50
horheynm pushed a commit that referenced this pull request Jul 6, 2023
Co-authored-by: andy <andy@neuralmagic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants