Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require torchvision<0.14 rather than torchvision<=0.13 #1034

Merged
merged 3 commits into from
May 23, 2023

Conversation

mgoin
Copy link
Member

@mgoin mgoin commented May 23, 2023

DeepSparse integration tests have been failing because we are restrictive on hotfix version for torchvision
We require torch==1.12.1 but restrict to torchvision==0.13 rather than allow 0.13.1

The conflict is caused by:
    deepsparse-nightly[dev,haystack,image-classification,server,transformers] 1.5.0 depends on torch==1.12.1; extra == "haystack"
    sentence-transformers 2.2.0 depends on torch>=1.6.0
    torchvision 0.13.0 depends on torch==1.12.0

https://github.com/neuralmagic/deepsparse/actions/runs/5010952108/jobs/8981291327

My proposed fix is to change torchvision>=0.3.0,<=0.13 to torchvision>=0.3.0,<0.14

Also, fix the SparseZoo change to use repo_name rather than model_id for the cache filepath

@mgoin mgoin requested review from a team, ohaijen, tdg5 and robertgshaw2-neuralmagic and removed request for a team May 23, 2023 19:58
@mgoin mgoin merged commit 5f54cfc into main May 23, 2023
7 checks passed
@mgoin mgoin deleted the torchvision-0.13-hotfix branch May 23, 2023 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant