Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cherry-pick] default num_cores in benchmark_model fn (#1018) #1019

Merged
merged 1 commit into from
May 2, 2023
Merged

[cherry-pick] default num_cores in benchmark_model fn (#1018) #1019

merged 1 commit into from
May 2, 2023

Commits on May 2, 2023

  1. default num_cores in benchmark_model fn (#1018) 

    * default num_cores in `benchmark_model` fn

`num_cores` is properly defaulted in the benchmark model CLI but not python API function call. this can cause errors with operating over the `None` default value in that scenario.

This PR adds a fix to provide a default when `None` is specified

* quality
    @bfineran
    bfineran committed May 2, 2023
    Configuration menu
    Copy the full SHA
    ccfe95d View commit details
    Browse the repository at this point in the history