Add retry attempts to refresh #1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1583 +/- ##
=======================================
Coverage ? 67.30%
=======================================
Files ? 261
Lines ? 12380
Branches ? 0
=======================================
Hits ? 8332
Misses ? 3525
Partials ? 523 ☔ View full report in Codecov by Sentry. |
glazychev-art
force-pushed
the
refresh_retry
branch
from
aeebd2b
to
65af2e6
Compare
glazychev-art
force-pushed
the
refresh_retry
branch
20 times, most recently
from
7730c4e
to
40ba527
Compare
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
glazychev-art
force-pushed
the
refresh_retry
branch
from
40ba527
to
5198c91
Compare
| ) | ||
|
|
||
| // ClientBackward checks the connection on the way back | ||
| type ClientBackward struct { |
There was a problem hiding this comment.
Instead of creating a new chain element, I'd suggest updating the count chain element to support the backward counters
|
@edwarnicke I think we need to go with this patch; it solves most of the scenarios that I described here: #1565. and this patch allows us to quickly schedule a check for networkservicemesh/cmd-forwarder-vpp#664. |
denis-tingaikin
approved these changes
Feb 6, 2024
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
nsmbot
pushed a commit
to networkservicemesh/cmd-csi-driver
that referenced
this pull request
Feb 12, 2024
…k@main PR link: networkservicemesh/sdk#1583 Commit: b1a3e26 Author: Artem Glazychev Date: 2024-02-12 17:51:49 +0700 Message: - Add retry attempts to refresh (#1583) * Add retry attempts to refresh Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * count chain element review comment Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-map-ip-k8s
that referenced
this pull request
Feb 12, 2024
…k@main PR link: networkservicemesh/sdk#1583 Commit: b1a3e26 Author: Artem Glazychev Date: 2024-02-12 17:51:49 +0700 Message: - Add retry attempts to refresh (#1583) * Add retry attempts to refresh Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * count chain element review comment Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Feb 12, 2024
…k@main PR link: networkservicemesh/sdk#1583 Commit: b1a3e26 Author: Artem Glazychev Date: 2024-02-12 17:51:49 +0700 Message: - Add retry attempts to refresh (#1583) * Add retry attempts to refresh Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * count chain element review comment Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-ipam-vl3
that referenced
this pull request
Feb 12, 2024
…k@main PR link: networkservicemesh/sdk#1583 Commit: b1a3e26 Author: Artem Glazychev Date: 2024-02-12 17:51:49 +0700 Message: - Add retry attempts to refresh (#1583) * Add retry attempts to refresh Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * count chain element review comment Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-dashboard-backend
that referenced
this pull request
Feb 12, 2024
…k@main PR link: networkservicemesh/sdk#1583 Commit: b1a3e26 Author: Artem Glazychev Date: 2024-02-12 17:51:49 +0700 Message: - Add retry attempts to refresh (#1583) * Add retry attempts to refresh Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * count chain element review comment Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Feb 12, 2024
…k@main PR link: networkservicemesh/sdk#1583 Commit: b1a3e26 Author: Artem Glazychev Date: 2024-02-12 17:51:49 +0700 Message: - Add retry attempts to refresh (#1583) * Add retry attempts to refresh Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * count chain element review comment Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Feb 12, 2024
…k@main PR link: networkservicemesh/sdk#1583 Commit: b1a3e26 Author: Artem Glazychev Date: 2024-02-12 17:51:49 +0700 Message: - Add retry attempts to refresh (#1583) * Add retry attempts to refresh Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * count chain element review comment Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-cluster-info-k8s
that referenced
this pull request
Feb 12, 2024
…k@main PR link: networkservicemesh/sdk#1583 Commit: b1a3e26 Author: Artem Glazychev Date: 2024-02-12 17:51:49 +0700 Message: - Add retry attempts to refresh (#1583) * Add retry attempts to refresh Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * count chain element review comment Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Feb 12, 2024
…k@main PR link: networkservicemesh/sdk#1583 Commit: b1a3e26 Author: Artem Glazychev Date: 2024-02-12 17:51:49 +0700 Message: - Add retry attempts to refresh (#1583) * Add retry attempts to refresh Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * count chain element review comment Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-remote-vlan
that referenced
this pull request
Feb 12, 2024
…k@main PR link: networkservicemesh/sdk#1583 Commit: b1a3e26 Author: Artem Glazychev Date: 2024-02-12 17:51:49 +0700 Message: - Add retry attempts to refresh (#1583) * Add retry attempts to refresh Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * count chain element review comment Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Feb 12, 2024
…k@main PR link: networkservicemesh/sdk#1583 Commit: b1a3e26 Author: Artem Glazychev Date: 2024-02-12 17:51:49 +0700 Message: - Add retry attempts to refresh (#1583) * Add retry attempts to refresh Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * count chain element review comment Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Feb 12, 2024
…k@main PR link: networkservicemesh/sdk#1583 Commit: b1a3e26 Author: Artem Glazychev Date: 2024-02-12 17:51:49 +0700 Message: - Add retry attempts to refresh (#1583) * Add retry attempts to refresh Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * count chain element review comment Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Feb 12, 2024
…k@main PR link: networkservicemesh/sdk#1583 Commit: b1a3e26 Author: Artem Glazychev Date: 2024-02-12 17:51:49 +0700 Message: - Add retry attempts to refresh (#1583) * Add retry attempts to refresh Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * count chain element review comment Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
Feb 12, 2024
…k@main PR link: networkservicemesh/sdk#1583 Commit: b1a3e26 Author: Artem Glazychev Date: 2024-02-12 17:51:49 +0700 Message: - Add retry attempts to refresh (#1583) * Add retry attempts to refresh Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * count chain element review comment Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Feb 12, 2024
…k@main PR link: networkservicemesh/sdk#1583 Commit: b1a3e26 Author: Artem Glazychev Date: 2024-02-12 17:51:49 +0700 Message: - Add retry attempts to refresh (#1583) * Add retry attempts to refresh Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * count chain element review comment Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a refresh retry functionality.
If the refresh fails, it is attempted again after a few ms (200 ms by default)
Issue link
#1565
How Has This Been Tested?
Types of changes