Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] begin should use eventFactory #1580

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

glazychev-art
Copy link
Contributor

@glazychev-art glazychev-art commented Jan 31, 2024

Description

Issue link

Issue: #1565

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionality
  • Documentation
  • Refactoring
  • CI

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@90f0c79). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1580   +/-   ##
=======================================
  Coverage        ?   67.64%           
=======================================
  Files           ?      261           
  Lines           ?    12416           
  Branches        ?        0           
=======================================
  Hits            ?     8399           
  Misses          ?     3501           
  Partials        ?      516           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glazychev-art glazychev-art force-pushed the begin_event_factory branch 2 times, most recently from 75fd3be to cb92e4f Compare January 31, 2024 06:37
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant