Fix InitialRegistrationTime in case of reregistration #1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1456 +/- ##
=======================================
Coverage ? 70.39%
=======================================
Files ? 248
Lines ? 11166
Branches ? 0
=======================================
Hits ? 7860
Misses ? 2807
Partials ? 499 ☔ View full report in Codecov by Sentry. |
glazychev-art
force-pushed
the
fix_reg_time
branch
18 times, most recently
from
3069dab
to
90aaaa2
Compare
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
glazychev-art
force-pushed
the
fix_reg_time
branch
from
90aaaa2
to
aaac75e
Compare
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
glazychev-art
force-pushed
the
fix_reg_time
branch
from
454fad3
to
d8b63a1
Compare
denis-tingaikin
approved these changes
May 18, 2023
There was a problem hiding this comment.
@glazychev-art I think we should also update sdk-k8s/chains/registry-k8s with metadata.
nsmbot
pushed a commit
to networkservicemesh/cmd-map-ip-k8s
that referenced
this pull request
May 18, 2023
…k@main PR link: networkservicemesh/sdk#1456 Commit: 63043b2 Author: Artem Glazychev Date: 2023-05-18 20:31:10 +0700 Message: - Fix InitialRegistrationTime in case of reregistration (#1456) * Fix InitialRegistrationTime in case of reregistration Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Add registry metadata Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Use metadata for setregistrationtime Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * linter fix Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-ipam-vl3
that referenced
this pull request
May 18, 2023
…k@main PR link: networkservicemesh/sdk#1456 Commit: 63043b2 Author: Artem Glazychev Date: 2023-05-18 20:31:10 +0700 Message: - Fix InitialRegistrationTime in case of reregistration (#1456) * Fix InitialRegistrationTime in case of reregistration Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Add registry metadata Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Use metadata for setregistrationtime Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * linter fix Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
May 18, 2023
…k@main PR link: networkservicemesh/sdk#1456 Commit: 63043b2 Author: Artem Glazychev Date: 2023-05-18 20:31:10 +0700 Message: - Fix InitialRegistrationTime in case of reregistration (#1456) * Fix InitialRegistrationTime in case of reregistration Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Add registry metadata Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Use metadata for setregistrationtime Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * linter fix Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
May 18, 2023
…k@main PR link: networkservicemesh/sdk#1456 Commit: 63043b2 Author: Artem Glazychev Date: 2023-05-18 20:31:10 +0700 Message: - Fix InitialRegistrationTime in case of reregistration (#1456) * Fix InitialRegistrationTime in case of reregistration Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Add registry metadata Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Use metadata for setregistrationtime Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * linter fix Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
May 18, 2023
…k@main PR link: networkservicemesh/sdk#1456 Commit: 63043b2 Author: Artem Glazychev Date: 2023-05-18 20:31:10 +0700 Message: - Fix InitialRegistrationTime in case of reregistration (#1456) * Fix InitialRegistrationTime in case of reregistration Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Add registry metadata Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Use metadata for setregistrationtime Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * linter fix Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
May 18, 2023
…k@main PR link: networkservicemesh/sdk#1456 Commit: 63043b2 Author: Artem Glazychev Date: 2023-05-18 20:31:10 +0700 Message: - Fix InitialRegistrationTime in case of reregistration (#1456) * Fix InitialRegistrationTime in case of reregistration Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Add registry metadata Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Use metadata for setregistrationtime Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * linter fix Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
May 18, 2023
…k@main PR link: networkservicemesh/sdk#1456 Commit: 63043b2 Author: Artem Glazychev Date: 2023-05-18 20:31:10 +0700 Message: - Fix InitialRegistrationTime in case of reregistration (#1456) * Fix InitialRegistrationTime in case of reregistration Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Add registry metadata Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Use metadata for setregistrationtime Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * linter fix Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-cluster-info-k8s
that referenced
this pull request
May 18, 2023
…k@main PR link: networkservicemesh/sdk#1456 Commit: 63043b2 Author: Artem Glazychev Date: 2023-05-18 20:31:10 +0700 Message: - Fix InitialRegistrationTime in case of reregistration (#1456) * Fix InitialRegistrationTime in case of reregistration Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Add registry metadata Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Use metadata for setregistrationtime Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * linter fix Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
May 18, 2023
…k@main PR link: networkservicemesh/sdk#1456 Commit: 63043b2 Author: Artem Glazychev Date: 2023-05-18 20:31:10 +0700 Message: - Fix InitialRegistrationTime in case of reregistration (#1456) * Fix InitialRegistrationTime in case of reregistration Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Add registry metadata Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Use metadata for setregistrationtime Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * linter fix Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
May 18, 2023
…k@main PR link: networkservicemesh/sdk#1456 Commit: 63043b2 Author: Artem Glazychev Date: 2023-05-18 20:31:10 +0700 Message: - Fix InitialRegistrationTime in case of reregistration (#1456) * Fix InitialRegistrationTime in case of reregistration Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Add registry metadata Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Use metadata for setregistrationtime Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * linter fix Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
May 18, 2023
…k@main PR link: networkservicemesh/sdk#1456 Commit: 63043b2 Author: Artem Glazychev Date: 2023-05-18 20:31:10 +0700 Message: - Fix InitialRegistrationTime in case of reregistration (#1456) * Fix InitialRegistrationTime in case of reregistration Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Add registry metadata Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Use metadata for setregistrationtime Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * linter fix Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-remote-vlan
that referenced
this pull request
May 18, 2023
…k@main PR link: networkservicemesh/sdk#1456 Commit: 63043b2 Author: Artem Glazychev Date: 2023-05-18 20:31:10 +0700 Message: - Fix InitialRegistrationTime in case of reregistration (#1456) * Fix InitialRegistrationTime in case of reregistration Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Add registry metadata Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Use metadata for setregistrationtime Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * linter fix Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
May 18, 2023
…k@main PR link: networkservicemesh/sdk#1456 Commit: 63043b2 Author: Artem Glazychev Date: 2023-05-18 20:31:10 +0700 Message: - Fix InitialRegistrationTime in case of reregistration (#1456) * Fix InitialRegistrationTime in case of reregistration Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Add registry metadata Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Use metadata for setregistrationtime Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * linter fix Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We should not change the
InitialRegistrationTimefield if we have already registered the NSE before.Added registry
metadatachain elementIssue link
networkservicemesh/deployments-k8s#9063
How Has This Been Tested?
Types of changes