Add memifproxy chain element #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwarnicke
force-pushed
the
memifproxy
branch
5 times, most recently
from
99d6043
to
05eb94d
Compare
If a client receives an fd for a unix file socket via grpcfd,
then it is possible that vpp will be unable to open that file in its
/proc/${pid}/fd/${fd} form. This is because while the receiving
client process gets the rights to that open file, vpp doesn't necessarily
have them.
In order to resolve this issue, the receiving client proxies the memif
control socket communications bilaterally.
Signed-off-by: Ed Warnicke <hagbard@gmail.com>
edwarnicke
force-pushed
the
memifproxy
branch
from
05eb94d
to
fa0b0a9
Compare
denis-tingaikin
approved these changes
Feb 8, 2021
There was a problem hiding this comment.
Tested this on my local machine.
My result is:
user@pc:~$ kubectl get pods -n ns-szkmm
NAME READY STATUS RESTARTS AGE
nsc-7fd9649b5b-5h25c 1/1 Running 0 3m24s
nse-669c4fc458-2wj4b 1/1 Running 0 3m24s
user@pc:~$ kubectl exec -ti -n ns-szkmm nsc-7fd9649b5b-5h25c -- vppctl show int addr
local0 (dn):
memif1/0 (up):
L3 172.16.1.101/32
user@pc:~$ kubectl exec -ti -n ns-szkmm nse-669c4fc458-2wj4b -- vppctl show int addr
local0 (dn):
memif1/0 (up):
L3 172.16.1.100/32
user@pc:~$ kubectl exec -ti -n ns-szkmm nsc-7fd9649b5b-5h25c -- vppctl ping 172.16.1.100 repeat 1
116 bytes from 172.16.1.100: icmp_seq=1 ttl=64 time=5.3789 ms
Statistics: 1 sent, 1 received, 0% packet loss
user@pc:~$ kubectl exec -ti -n ns-szkmm nse-669c4fc458-2wj4b -- vppctl ping 172.16.1.101 repeat 1
116 bytes from 172.16.1.101: icmp_seq=1 ttl=64 time=2.0970 ms
Statistics: 1 sent, 1 received, 0% packet loss
So I guess we need to merge this.
@edwarnicke Do you plan to add something?
|
I feel it's ready to merge :) |
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-vpp
that referenced
this pull request
Feb 8, 2021
…k-vpp@main networkservicemesh/sdk-vpp#84 networkservicemesh/sdk-vpp PR link: networkservicemesh/sdk-vpp#84 networkservicemesh/sdk-vpp commit message: commit bbccef9118bd363f0de93841794a449fa5c34ce7 Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Tue Feb 9 03:28:38 2021 +0700 Merge pull request #84 from edwarnicke/memifproxy Add memifproxy chain element Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
that referenced
this pull request
Mar 31, 2021
…k@master networkservicemesh/sdk# networkservicemesh/sdk PR link: https://github.com/networkservicemesh/sdk/pull/ networkservicemesh/sdk commit message: commit 68a6beb665573871298efe7915504905ef495176 Author: Network Service Mesh Bot <60070799+nsmbot@users.noreply.github.com> Date: Wed Mar 31 09:44:17 2021 -0500 Update go.mod and go.sum to latest version from networkservicemesh/api@master networkservicemesh/api# (#801) networkservicemesh/api PR link: https://github.com/networkservicemesh/api/pull/ networkservicemesh/api commit message: commit 12761e9f673f833b4484efba6b40a56bc5df27c5 Author: Lionel Jouin <LionelJouin@users.noreply.github.com> Date: Wed Mar 31 16:38:34 2021 +0200 Fix EvenVNI function (#84) Signed-off-by: Lionel Jouin <lionel.jouin@est.tech> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> Co-authored-by: NSMBot <nsmbot@networkservicmesh.io> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
that referenced
this pull request
Mar 31, 2021
…k@master networkservicemesh/sdk#801 networkservicemesh/sdk PR link: networkservicemesh/sdk#801 networkservicemesh/sdk commit message: commit 68a6beb665573871298efe7915504905ef495176 Author: Network Service Mesh Bot <60070799+nsmbot@users.noreply.github.com> Date: Wed Mar 31 09:44:17 2021 -0500 Update go.mod and go.sum to latest version from networkservicemesh/api@master networkservicemesh/api# (#801) networkservicemesh/api PR link: https://github.com/networkservicemesh/api/pull/ networkservicemesh/api commit message: commit 12761e9f673f833b4484efba6b40a56bc5df27c5 Author: Lionel Jouin <LionelJouin@users.noreply.github.com> Date: Wed Mar 31 16:38:34 2021 +0200 Fix EvenVNI function (#84) Signed-off-by: Lionel Jouin <lionel.jouin@est.tech> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> Co-authored-by: NSMBot <nsmbot@networkservicmesh.io> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.