Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set memif_rx_mode on a separate chain element #670

Merged
merged 1 commit into from
Dec 14, 2022
Merged

Set memif_rx_mode on a separate chain element #670

merged 1 commit into from
Dec 14, 2022

Conversation

glazychev-art
Copy link
Contributor

@glazychev-art glazychev-art commented Dec 14, 2022 •
edited
Loading

Description

Issue: networkservicemesh/cmd-nse-vl3-vpp#136

It turned out that we can set the rx_mode value for memif only after creating a connection, when the master and slave are configured and the interfaces are up. Only then does the mode setting work.

In this PR, a new chain element was added, which in the goroutine monitors events from the interface and waits LINK_UP. After that, sets the ADAPTIVE mode.

A new element and a goroutine were needed, since we up the interfaces at the last stage, when the Request has already passed the client and server.

Signed-off-by: Artem Glazychev artem.glazychev@xored.com

@glazychev-art
Set memif_rx_mode on a separate chain element
b83ff79 
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
@edwarnicke edwarnicke merged commit 4bc0261 into networkservicemesh:main Dec 14, 2022
nsmbot pushed a commit to networkservicemesh/cmd-nse-vl3-vpp that referenced this pull request Dec 14, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
f5b6b64 
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#670

Commit: 4bc0261
Author: Artem Glazychev
Date: 2022-12-14 21:01:19 +0700
Message:
  - Set memif_rx_mode on a separate chain element (#670)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-firewall-vpp that referenced this pull request Dec 14, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
1c79c40 
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#670

Commit: 4bc0261
Author: Artem Glazychev
Date: 2022-12-14 21:01:19 +0700
Message:
  - Set memif_rx_mode on a separate chain element (#670)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-vpp that referenced this pull request Dec 14, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
d28927b 
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#670

Commit: 4bc0261
Author: Artem Glazychev
Date: 2022-12-14 21:01:19 +0700
Message:
  - Set memif_rx_mode on a separate chain element (#670)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vlan-vpp that referenced this pull request Dec 14, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
cf4df9f 
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#670

Commit: 4bc0261
Author: Artem Glazychev
Date: 2022-12-14 21:01:19 +0700
Message:
  - Set memif_rx_mode on a separate chain element (#670)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-simple-docker that referenced this pull request Dec 14, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
9592d22 
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#670

Commit: 4bc0261
Author: Artem Glazychev
Date: 2022-12-14 21:01:19 +0700
Message:
  - Set memif_rx_mode on a separate chain element (#670)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-icmp-responder-vpp that referenced this pull request Dec 14, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
a030f4d 
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#670

Commit: 4bc0261
Author: Artem Glazychev
Date: 2022-12-14 21:01:19 +0700
Message:
  - Set memif_rx_mode on a separate chain element (#670)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-forwarder-vpp that referenced this pull request Dec 14, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
31d96a3 
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#670

Commit: 4bc0261
Author: Artem Glazychev
Date: 2022-12-14 21:01:19 +0700
Message:
  - Set memif_rx_mode on a separate chain element (#670)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-simple-vl3-docker that referenced this pull request Dec 14, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
9138efb 
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#670

Commit: 4bc0261
Author: Artem Glazychev
Date: 2022-12-14 21:01:19 +0700
Message:
  - Set memif_rx_mode on a separate chain element (#670)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Dec 14, 2022
Closed
Closed
Closed
Merged
Merged
Merged
denis-tingaikin pushed a commit to networkservicemesh/cmd-nsc-vpp that referenced this pull request Dec 14, 2022
@glazychev-art
Update sdk-vpp with latest memif changes (#516)
4a77d4e 
* Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main
PR link: networkservicemesh/sdk-vpp#670

Commit: 4bc0261
Author: Artem Glazychev
Date: 2022-12-14 21:01:19 +0700
Message:
  - Set memif_rx_mode on a separate chain element (#670)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>

* Update sdk-vpp with latest memif changes

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
denis-tingaikin pushed a commit to networkservicemesh/cmd-forwarder-vpp that referenced this pull request Dec 14, 2022
@glazychev-art
Update sdk-vpp with latest memif changes (#777)
3df2974 
* Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main
PR link: networkservicemesh/sdk-vpp#670

Commit: 4bc0261
Author: Artem Glazychev
Date: 2022-12-14 21:01:19 +0700
Message:
  - Set memif_rx_mode on a separate chain element (#670)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>

* Update sdk-vpp with latest memif changes

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/deployments-k8s that referenced this pull request Dec 14, 2022
Update go.mod and go.sum to latest version from networkservicemesh/cm…
ac56046 
…d-forwarder-vpp@main

PR link: networkservicemesh/cmd-forwarder-vpp#777

Commit: 3df2974
Author: Artem Glazychev
Date: 2022-12-15 04:28:02 +0700
Message:
  - Update sdk-vpp with latest memif changes (#777)
* Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main
PR link: networkservicemesh/sdk-vpp#670

Commit: 4bc0261
Author: Artem Glazychev
Date: 2022-12-14 21:01:19 +0700
Message:
    - Set memif_rx_mode on a separate chain element (#670)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>

* Update sdk-vpp with latest memif changes

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@nsmbot nsmbot mentioned this pull request Dec 14, 2022
Merged
nsmbot pushed a commit to networkservicemesh/deployments-k8s that referenced this pull request Dec 14, 2022
Update go.mod and go.sum to latest version from networkservicemesh/cm…
ce012b5 
…d-nsc-vpp@main

PR link: networkservicemesh/cmd-nsc-vpp#516

Commit: 4a77d4e
Author: Artem Glazychev
Date: 2022-12-15 04:27:47 +0700
Message:
  - Update sdk-vpp with latest memif changes (#516)
* Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main
PR link: networkservicemesh/sdk-vpp#670

Commit: 4bc0261
Author: Artem Glazychev
Date: 2022-12-14 21:01:19 +0700
Message:
    - Set memif_rx_mode on a separate chain element (#670)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>

* Update sdk-vpp with latest memif changes

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
denis-tingaikin pushed a commit to networkservicemesh/deployments-k8s that referenced this pull request Dec 15, 2022
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/cm…
f7d8ee0 
…d-nsc-vpp@main (#8093)

PR link: networkservicemesh/cmd-nsc-vpp#516

Commit: 4a77d4e
Author: Artem Glazychev
Date: 2022-12-15 04:27:47 +0700
Message:
  - Update sdk-vpp with latest memif changes (#516)
* Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main
PR link: networkservicemesh/sdk-vpp#670

Commit: 4bc0261
Author: Artem Glazychev
Date: 2022-12-14 21:01:19 +0700
Message:
    - Set memif_rx_mode on a separate chain element (#670)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>

* Update sdk-vpp with latest memif changes

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit that referenced this pull request Aug 1, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
75687a0 
…k-kernel@main

PR link: networkservicemesh/sdk-kernel#670

Commit: 418a2f4
Author: Network Service Mesh Bot
Date: 2024-08-01 04:21:54 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#670)
PR link: networkservicemesh/sdk#1643
Commit: bc1d964
Author: Nikita Skrynnik
Date: 2024-08-01 20:19:08 +1100
Message:
    - Leak fixes (#1643)
* update grpcfd (#1640)
* fix monitor
* fix CI
* add unit tests + fix some errors
* add unit tests
* fix CI
* cleanup
---------
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot added a commit that referenced this pull request Aug 1, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/sd…
9d48d2c 
…k-kernel@main (#840)

PR link: networkservicemesh/sdk-kernel#670

Commit: 418a2f4
Author: Network Service Mesh Bot
Date: 2024-08-01 04:21:54 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#670)
PR link: networkservicemesh/sdk#1643
Commit: bc1d964
Author: Nikita Skrynnik
Date: 2024-08-01 20:19:08 +1100
Message:
    - Leak fixes (#1643)
* update grpcfd (#1640)
* fix monitor
* fix CI
* add unit tests + fix some errors
* add unit tests
* fix CI
* cleanup
---------

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwarnicke edwarnicke Awaiting requested review from edwarnicke

@denis-tingaikin denis-tingaikin Awaiting requested review from denis-tingaikin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glazychev-art @edwarnicke