-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix release and pr-for-updates workflows #430
Merged
denis-tingaikin
merged 7 commits into
networkservicemesh:main
from
NikitaSkrynnik:fix-reusable-workflows
Jul 1, 2022
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a54007d
fix release and pr-for-updates workflows
NikitaSkrynnik b588373
fix linter
NikitaSkrynnik 934e2ab
fix linter
NikitaSkrynnik e569f25
fix dependent-repos list
NikitaSkrynnik 13aba39
cleanup
NikitaSkrynnik 9c6b5e9
fix linter
NikitaSkrynnik 9dd41cd
move constants to client_test.go file
NikitaSkrynnik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,58 +1,11 @@ | ||
--- | ||
name: Release | ||
name: Pull Request on update/* Branch Push | ||
on: | ||
workflow_run: | ||
types: | ||
- completed | ||
workflows: | ||
- "ci" | ||
push: | ||
branches: | ||
- update/** | ||
jobs: | ||
print-debug-info: | ||
name: Print debug info for Release workflow | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: hmarr/debug-action@v2 | ||
|
||
get-tag: | ||
name: Get tag | ||
runs-on: ubuntu-latest | ||
if: ${{ github.event.workflow_run.conclusion == 'success' && contains(github.event.workflow_run.head_branch, 'release/') }} | ||
outputs: | ||
tag: ${{ steps.get-tag-step.outputs.tag }} | ||
steps: | ||
- name: Get tag | ||
run: | | ||
branch=${{github.event.workflow_run.head_branch}} | ||
echo '::set-output name=tag::'${branch#release/} | ||
id: get-tag-step | ||
|
||
create-release: | ||
name: Create release | ||
needs: get-tag | ||
uses: networkservicemesh/.github/.github/workflows/release.yaml@main | ||
with: | ||
tag: ${{ needs.get-tag.outputs.tag }} | ||
secrets: | ||
token: ${{ secrets.NSM_BOT_GITHUB_TOKEN }} | ||
|
||
release-dependent-repositories: | ||
name: Release dependent repositories | ||
needs: [get-tag, create-release] | ||
uses: networkservicemesh/.github/.github/workflows/release-dependent-repositories.yaml@main | ||
with: | ||
tag: ${{ needs.get-tag.outputs.tag }} | ||
dependent_repositories: | | ||
["sdk-k8s", | ||
"sdk-kernel", | ||
"cmd-nsmgr", | ||
"cmd-nsmgr-proxy", | ||
"cmd-registry-memory", | ||
"cmd-registry-proxy-dns", | ||
"cmd-nse-remote-vlan", | ||
"cmd-nse-vfio", | ||
"cmd-nsc-init", | ||
"cmd-ipam-vl3", | ||
"cmd-map-ip-k8s", | ||
"cmd-admission-webhook-k8s"] | ||
auto-pull-request: | ||
uses: networkservicemesh/.github/.github/workflows/pr-for-updates.yaml@main | ||
secrets: | ||
token: ${{ secrets.NSM_BOT_GITHUB_TOKEN }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was it deleted?
It is used here - https://github.com/networkservicemesh/sdk-sriov/blob/main/pkg/networkservice/common/mechanisms/vfio/client_test.go#L60
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linter says that it is unused https://github.com/networkservicemesh/sdk-sriov/runs/7129829384?check_suite_focus=true#step:4:27
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of this commit - 9d3fdb5
Need to figure out how to avoid this problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can just move this constant to client_test.go file