Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automerge job ca stuck and do not merge green PRs from NSMBot #475

Closed
denis-tingaikin opened this issue Mar 5, 2021 · 3 comments · Fixed by #507
Closed

Automerge job ca stuck and do not merge green PRs from NSMBot #475

denis-tingaikin opened this issue Mar 5, 2021 · 3 comments · Fixed by #507
Labels
bug Something isn't working

Comments

@denis-tingaikin
Copy link
Member

denis-tingaikin commented Mar 5, 2021 •
edited
Loading

Problem

Actual:
image
Expected: All green PRs from NSMBot should be merged.

We need to investigate and fix this.
@denis-tingaikin denis-tingaikin added the bug Something isn't working label Mar 5, 2021
@denis-tingaikin
Copy link
Member Author

Found error in logs of auto-merge job: Pull request is not in a mergeable state: UNKNOWN.

@denis-tingaikin
Copy link
Member Author

@edwarnicke I see here these options at this moment:

  1. Use another action: https://github.com/pascalgn/automerge-action.
  2. Try to patch ridedott/merge-me-action (looks like it should retry do merge after some period for PRs in UNKNOWN state).
  3. Do ridedott/merge-me-action twice.
  4. Your option.

For me option 1 looks good, but Im not sure at 100% that it solves the issue.

@edwarnicke
Copy link
Member

@denis-tingaikin I'm not in any way attached to our current auto-merge action... so if another one looks better or more stable, I'm in favor of changing :)

@denis-tingaikin denis-tingaikin changed the title Automerge job can be stuck and do not merge green PRs from NSMBot Automerge job ca stuck and do not merge green PRs from NSMBot Mar 12, 2021
@denis-tingaikin denis-tingaikin mentioned this issue Mar 12, 2021
Merged
nsmbot pushed a commit that referenced this issue Sep 19, 2022
Update go.mod and go.sum to latest version from networkservicemesh/cm…
fabd929 
…d-nse-icmp-responder-vpp@main

PR link: networkservicemesh/cmd-nse-icmp-responder-vpp#475

Commit: c831d7d
Author: Denis Tingaikin
Date: 2022-09-19 13:27:55 +0300
Message:
  - Merge pull request #475 from glazychev-art/cidr_groups
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit that referenced this issue May 16, 2024
Update go.mod and go.sum to latest version from networkservicemesh/cm…
561b88a 
…d-nse-vlan-vpp@main

PR link: networkservicemesh/cmd-nse-vlan-vpp#475

Commit: 45cbade
Author: Network Service Mesh Bot
Date: 2024-05-16 03:12:16 -0500
Message:
  - Update from update/networkservicemesh/sdk-sriov (#475)
* Update go.mod and go.sum to latest version from networkservicemesh/sdk-sriov@main
PR link: networkservicemesh/sdk-sriov#594
Commit: 7fee1a7
Author: Network Service Mesh Bot
Date: 2024-05-16 03:05:40 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#594)
PR link: networkservicemesh/sdk-kernel#663
Commit: 6a362bb
Author: Network Service Mesh Bot
Date: 2024-05-16 03:01:48 -0500
Message:
        - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#663)
PR link: networkservicemesh/sdk#1623
Commit: 3b79590
Author: Nikita Skrynnik
Date: 2024-05-16 18:55:35 +1100
Message:
                - Fix some leaks in authorize chain elements (#1623)
* fix some leaks in authorize chain elements
* fix go linter issues
* add tests for memory leaks
* fix go linter issues
* rerun CI
---------
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
* Automatically resolving conflicts in go.mod and updating dependency versions to the latest
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
---------
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot added a commit that referenced this issue May 16, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/cm…
afe9c96 
…d-nse-vlan-vpp@main (#12008)

PR link: networkservicemesh/cmd-nse-vlan-vpp#475

Commit: 45cbade
Author: Network Service Mesh Bot
Date: 2024-05-16 03:12:16 -0500
Message:
  - Update from update/networkservicemesh/sdk-sriov (#475)
* Update go.mod and go.sum to latest version from networkservicemesh/sdk-sriov@main
PR link: networkservicemesh/sdk-sriov#594
Commit: 7fee1a7
Author: Network Service Mesh Bot
Date: 2024-05-16 03:05:40 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#594)
PR link: networkservicemesh/sdk-kernel#663
Commit: 6a362bb
Author: Network Service Mesh Bot
Date: 2024-05-16 03:01:48 -0500
Message:
        - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#663)
PR link: networkservicemesh/sdk#1623
Commit: 3b79590
Author: Nikita Skrynnik
Date: 2024-05-16 18:55:35 +1100
Message:
                - Fix some leaks in authorize chain elements (#1623)
* fix some leaks in authorize chain elements
* fix go linter issues
* add tests for memory leaks
* fix go linter issues
* rerun CI
---------

* Automatically resolving conflicts in go.mod and updating dependency versions to the latest

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit that referenced this issue Sep 13, 2024
Update go.mod and go.sum to latest version from networkservicemesh/cm…
7aa9424 
…d-registry-k8s@main

PR link: networkservicemesh/cmd-registry-k8s#475

Commit: d0d7af0
Author: Network Service Mesh Bot
Date: 2024-09-13 07:50:39 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#475)
PR link: networkservicemesh/sdk-k8s#524
Commit: 1200fd4
Author: Denis Tingaikin
Date: 2024-09-13 15:47:33 +0300
Message:
    - Merge pull request #524 from Nordix/arp-remove-status
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot added a commit that referenced this issue Sep 13, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/cm…
47c4d36 
…d-registry-k8s@main (#12288)

PR link: networkservicemesh/cmd-registry-k8s#475

Commit: d0d7af0
Author: Network Service Mesh Bot
Date: 2024-09-13 07:50:39 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#475)
PR link: networkservicemesh/sdk-k8s#524
Commit: 1200fd4
Author: Denis Tingaikin
Date: 2024-09-13 15:47:33 +0300
Message:
    - Merge pull request #524 from Nordix/arp-remove-status

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@edwarnicke @denis-tingaikin