Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdk-vpp#357] Add missed helper methods for memif #117

Conversation

Bolodya1997
Copy link

Description

Continues #113.

Issue link

networkservicemesh/sdk-vpp#370

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edwarnicke There added two helper functions. So merging.

Let us know if we should revert this.

@denis-tingaikin denis-tingaikin merged commit 64784f3 into networkservicemesh:main Nov 3, 2021
nsmbot pushed a commit to networkservicemesh/sdk that referenced this pull request Nov 3, 2021
…i@main

PR link: networkservicemesh/api#117

Commit: 64784f3
Author: Vladimir Popov
Date: 2021-11-03 16:06:13 +0700
Message:
  - Add missed helper methods for memif (#117)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants