Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve accuracy of rounding with multipleOf #243

Merged
merged 2 commits into from
Dec 31, 2019

Conversation

seamusv
Copy link
Contributor

@seamusv seamusv commented Dec 30, 2019

Ensure the accuracy of the multipleOf contract.

@codecov-io
Copy link

codecov-io commented Dec 30, 2019

Codecov Report

Merging #243 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #243   +/-   ##
========================================
  Coverage      70.8%   70.8%           
  Complexity      575     575           
========================================
  Files            68      68           
  Lines          2264    2264           
  Branches        491     491           
========================================
  Hits           1603    1603           
  Misses          459     459           
  Partials        202     202
Impacted Files Coverage Δ Complexity Δ
...java/com/networknt/schema/MultipleOfValidator.java 87.5% <100%> (ø) 5 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d95b85b...0fac9c1. Read the comment docs.

@stevehu
Copy link
Contributor

stevehu commented Dec 30, 2019

@seamusv Thanks a lot for your contribution. This makes perfect sense and I am a little surprised that the official test case doesn't cover this scenario. Since we constantly sync the official test cases to our codebase, I think the best option for us is to separate the new test cases to another JSON file. At the same time, let's open an issue to add these to the official test suite. What do you think?

https://github.com/json-schema-org/JSON-Schema-Test-Suite

@seamusv
Copy link
Contributor Author

seamusv commented Dec 31, 2019

@stevehu I have moved the test data out of the official specifications and into a top-level JSON file. The test is only in the draft7 suite. I'll submit a PR to the official test suite repo.

@seamusv
Copy link
Contributor Author

seamusv commented Dec 31, 2019

I have submitted the request at json-schema-org/JSON-Schema-Test-Suite#321

@stevehu
Copy link
Contributor

stevehu commented Dec 31, 2019

@seamusv Thanks a lot for the effort. Whenever we have a separate file, it won't be overwritten.

@stevehu stevehu merged commit 3b50c53 into networknt:master Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants