-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README and config #475
Conversation
Codecov Report
@@ Coverage Diff @@
## main #475 +/- ##
=======================================
Coverage 66.03% 66.03%
=======================================
Files 94 94
Lines 6921 6921
=======================================
Hits 4570 4570
Misses 2092 2092
Partials 259 259
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@@ -437,6 +454,7 @@ parameters: | |||
filter: | |||
key: name | |||
value: dest_service_count | |||
filters: [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
filter
is deprecated in favor of filters
so we should convert these to arrays
filter: | ||
key: name | ||
key: "" | ||
value: "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since filter
is being deprecated, shouldn't we just delete this section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ronensc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Following the feedback of @aslom in #473:
make ocp-deploy
withIMAGE_ORG=netobserv
extract_aggregate
which required this update.flp_op_
(added underscore) to avoid metric names likeflp_opmetrics_processed