-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-1135: add ovs subsystem drop causes #472
NETOBSERV-1135: add ovs subsystem drop causes #472
Conversation
@msherif1234: This pull request references NETOBSERV-1135 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5d6be2a
to
5c70c00
Compare
Codecov Report
@@ Coverage Diff @@
## main #472 +/- ##
==========================================
- Coverage 66.08% 65.85% -0.24%
==========================================
Files 94 94
Lines 6877 6899 +22
==========================================
- Hits 4545 4543 -2
- Misses 2071 2094 +23
- Partials 261 262 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks ! 🚀
5c70c00
to
3db596d
Compare
OVS drop support just merged upstream https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/tree/net/openvswitch/drop.h Signed-off-by: msherif1234 <mmahmoud@redhat.com>
3db596d
to
b3679ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also fine with the new approach, merging switch / cases 👍
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msherif1234 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
OVS drop support just merged upstream
https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/tree/net/openvswitch/drop.h