-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-1197: Generalize TCPDrop to support more protocols #457
NETOBSERV-1197: Generalize TCPDrop to support more protocols #457
Conversation
Codecov Report
@@ Coverage Diff @@
## main #457 +/- ##
==========================================
- Coverage 66.20% 66.17% -0.03%
==========================================
Files 94 94
Lines 6808 6808
==========================================
- Hits 4507 4505 -2
- Misses 2046 2047 +1
- Partials 255 256 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/ok-to-test |
New image: quay.io/netobserv/flowlogs-pipeline:8deb6f9. It will expire after two weeks. |
@msherif1234: This pull request references NETOBSERV-1197 which is a valid jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@msherif1234: This pull request references NETOBSERV-1197 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
New image: quay.io/netobserv/flowlogs-pipeline:5209b52. It will expire after two weeks. |
/lgtm Seems just a rename |
@msherif1234 seems okay but there is a WIP tag with the PR heading. |
Thanks @dushyantbehl yeah it need to be updated with ebpf PR commit id |
Signed-off-by: msherif1234 <mmahmoud@redhat.com>
Signed-off-by: msherif1234 <mmahmoud@redhat.com>
/lgtm |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msherif1234 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
netobserv/netobserv-ebpf-agent#152 needs to be merged 1st then update netobserv-agent with the commit id