Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflow, setup workflow-test #438

Merged
merged 3 commits into from
May 24, 2023

Conversation

jotak
Copy link
Member

@jotak jotak commented May 24, 2023

  • Can trigger workflow from branch workflow-test
  • Make default multi-arch to single amd64
  • Remove specific ci targets; make shortlive builds more straightforward
  • Disambiguate makefile env vs workflow env
  • Remove unused targets
  • Remove now unused shortlived dockerfile

- Can trigger workflow from branch workflow-test
- Make default multi-arch to single amd64
- Remove specific ci targets; make shortlive builds more straightforward
- Disambiguate makefile env vs workflow env
- Remove unused targets
- Remove now unused shortlived dockerfile
@jotak
Copy link
Member Author

jotak commented May 24, 2023

Hold on, something wrong here: the per-PR sha isn't in quay

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #438 (d6790ee) into main (39d2e01) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #438      +/-   ##
==========================================
+ Coverage   64.71%   64.74%   +0.03%     
==========================================
  Files          94       94              
  Lines        6657     6657              
==========================================
+ Hits         4308     4310       +2     
+ Misses       2105     2104       -1     
+ Partials      244      243       -1     
Flag Coverage Δ
unittests 64.74% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@jotak
Copy link
Member Author

jotak commented May 24, 2023

Hold on, something wrong here: the per-PR sha isn't in quay

OK, my last commit fixed it

Seems all good now

jpinsonneau
jpinsonneau previously approved these changes May 24, 2023
Copy link
Collaborator

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jotak

@jotak
Copy link
Member Author

jotak commented May 24, 2023

I've pushed a new commit, to restore the latest tagging that I removed in the first place - will have to do so on other repos too

@msherif1234
Copy link
Contributor

/LGTM

@jotak
Copy link
Member Author

jotak commented May 24, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented May 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 9bebf7e into netobserv:main May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants