-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-974 Implement SASL for Kafka (producer+consumer) #424
Conversation
Codecov Report
@@ Coverage Diff @@
## main #424 +/- ##
==========================================
- Coverage 64.74% 64.36% -0.38%
==========================================
Files 94 96 +2
Lines 6651 6690 +39
==========================================
Hits 4306 4306
- Misses 2102 2139 +37
- Partials 243 245 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only a minor comment.
"github.com/segmentio/kafka-go/sasl/scram" | ||
) | ||
|
||
func SetupSASLMechanism(cfg *api.SASLConfig) (sasl.Mechanism, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: Since the function is tied to the kafka-go type sasl.Mechanism
may be it should be in the kafka ingest file.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.