-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conntrack: Add operational metrics on errors for hash computation and aggregators #416
conntrack: Add operational metrics on errors for hash computation and aggregators #416
Conversation
New image: quay.io/netobserv/flowlogs-pipeline:8fdf2a6. It will expire after two weeks. |
Codecov Report
@@ Coverage Diff @@
## main #416 +/- ##
==========================================
+ Coverage 64.62% 64.75% +0.13%
==========================================
Files 94 94
Lines 6629 6645 +16
==========================================
+ Hits 4284 4303 +19
+ Misses 2101 2099 -2
+ Partials 244 243 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in terms of code (not tested). Thanks @ronensc !
2d892af
to
7cc95d6
Compare
Rebased and added another operational metric to count how connections are getting ended per scheduling group, either by getting
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ronensc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR adds the following operational metrics that count errors during hash computation and in the aggregators.