This repository has been archived by the owner on May 22, 2024. It is now read-only.
Allow running "serveFunctions" without package.json #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses as the function "moduleDir" the first ".git" directory found by ascending the folder structure if "findModuleDir" returns false. If that still fails, uses "process.cwd()". Uses a shared memoized implementation for ascending directory finders.
|
we no longer serve functions in this repo - i'm still not sure if we need the functionality in this PR (i wasnt involved in this) but suggest moving it to netlify-dev-plugin. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Uses as the function "moduleDir" the first .git directory found by ascending the folder structure if "findModuleDirectory" returns false. If that still fails, uses "process.cwd()". Uses a shared memoized implementation for ascending directory finders.
This PR completes the work necessary in this repo to close #15.
- Test plan
Manually tested.
- Description for the changelog
Allow running "serveFunctions" without a package.json