This repository has been archived by the owner on Sep 12, 2019. It is now read-only.
fix serve functions.. and correct the root cause of localhost:30001 bug #71
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #58
this bug was directly caused because ZISI was expecting a full
settings
object: https://github.com/netlify/zip-it-and-ship-it/blob/306d26a4b1ff99bfe0ace291755e980040c2b2ae/src/serve.js#L154but we were only providing an object with functionsDir:
netlify-dev-plugin/src/commands/dev/index.js
Line 149 in b062da4
the indirect fix for this is to use typescript to better communicate & enforce contracts.