This repository has been archived by the owner on Sep 12, 2019. It is now read-only.
Fix async and callback combo handling #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AryanJ-NYC
reviewed
Apr 25, 2019
| const callback = createCallback(response); | ||
| const promise = handler.handler( | ||
| lambdaRequest, | ||
| { clientContext: buildClientContext(request.headers) || {} }, | ||
| callback | ||
| ); | ||
| promiseCallback(promise, callback); | ||
| /** guard against using BOTH async and callback */ |
AryanJ-NYC
reviewed
Apr 25, 2019
|
|
||
| promise.then( | ||
| function(data) { | ||
| console.log("hellooo"); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
closes #165
closes #142
- Description for the changelog
better dx when writing bad functions
better dx when reloading functions
- A picture of a cute animal (not mandatory but encouraged)
😻