This repository has been archived by the owner on Sep 12, 2019. It is now read-only.
Inject client context into functions #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yes i wanted this too but we punted on it for the launch. thanks for taking the initiative! |
swyxio
added a commit
that referenced
this pull request
Apr 18, 2019
Inject client context into functions
|
released in cli v2.11.11 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
When the Netlify function is invoked with an Authorization header containing a bearer token, this decodes the information inside the token and populates the client context, just like the production environment does.
This is a straight up port of the same functionality from this netlify-lambda PR and is crucial for local development of functions that use authentication.
Just like in netlify-lambda, this doesn't actually validate the token, it only decodes the public part and injects it into the invocation.
- Test plan
Proper testing support doesn't seem to be in place yet, so I tested this change by compiling the Netlify cli locally with this fork of the netlify-dev-plugin in place, and everything ran well.
The info is populated if you have a valid bearer token present, otherwise it's left empty as expected.
- Description for the changelog
Populate client context if authorization header with a bearer token is present in function invocation