Skip to content
This repository has been archived by the owner on Sep 12, 2019. It is now read-only.

fix: Enable flags for port and cmd #104

Merged
merged 3 commits into from
Apr 9, 2019
Merged

fix: Enable flags for port and cmd #104

merged 3 commits into from
Apr 9, 2019

Conversation

shortdiv
Copy link
Contributor

@shortdiv shortdiv commented Apr 8, 2019

- Summary
Currently, flags for cmd and port don't work. This PR ensures that flags are added and override the dev block config in the netlify.toml file.

- Test plan
Add the following dev block to your netlify.toml file:

[dev]
  command = "yarn start" 
  port = 3000
  publish = "dist"

Then run the following command: netlify dev --port 3000 or netlify dev --command="yarn start"

- Description for the changelog
This PR joins the option flags with the dev config in the netlify toml and ensures that the former overrides the latter.

- A picture of a cute animal (not mandatory but encouraged)

cute-squirrel-baby

@swyxio swyxio merged commit 74e206e into master Apr 9, 2019
@swyxio swyxio deleted the enable-flags branch April 9, 2019 05:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants