Skip to content
This repository has been archived by the owner on Sep 12, 2019. It is now read-only.

middleman detector: hasRequiredFiles is not defined #177

Closed
ridem opened this issue May 9, 2019 · 2 comments
Closed

middleman detector: hasRequiredFiles is not defined #177

ridem opened this issue May 9, 2019 · 2 comments

Comments

@ridem
Copy link

ridem commented May 9, 2019 •
edited
Loading

This detector doesn't require the hasRequiredFiles util, so calls to netlify dev fail.
src/detectors/middleman.js#L4

Bug introduced in PR #172

◈ Netlify Dev ◈
ReferenceError: hasRequiredFiles is not defined
    at Array.module.exports (.../netlify-cli/node_modules/netlify-dev-plugin/src/detectors/middleman.js:4:3)
    at module.exports.serverSettings (.../netlify-cli/node_modules/netlify-dev-plugin/src/detect-server.js:20:40)
    at DevCommand.run (.../netlify-cli/node_modules/netlify-dev-plugin/src/commands/dev/index.js:187:26)

netlify-cli/2.11.17 darwin-x64 node-v10.13.0 - MacOS 10.14.4
@jgarber623 jgarber623 mentioned this issue May 9, 2019
Merged
@swyxio
Copy link
Contributor

swyxio commented May 9, 2019

sorry for the bug. fixing

@swyxio swyxio closed this as completed in 284faac May 9, 2019
swyxio added a commit that referenced this issue May 9, 2019
@swyxio
Use existsSync instead of hasRequiredFiles (fixes #177) (#178)
758315d 
Use `existsSync` instead of `hasRequiredFiles` (fixes #177)
@swyxio
Copy link
Contributor

swyxio commented May 9, 2019

fixed release in v2.11.18, thanks @jgarber623 !

@swyxio swyxio mentioned this issue Aug 12, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ridem @swyxio