Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sysbox-installer-helper.sh invalid comparison of kernel version causing kernel 6.10 < 6.2 #131

Open
haseoleonard opened this issue Aug 15, 2024 · 2 comments
Open

sysbox-installer-helper.sh invalid comparison of kernel version causing kernel 6.10 < 6.2 #131

haseoleonard opened this issue Aug 15, 2024 · 2 comments

Comments

@haseoleonard
Copy link

Sysbox k8s deploy vevrsion: v0.6.4

image
@haseoleonard
Copy link
Author

the function is compare_ge() return incorrect on kernel 6.10-6.19 < 6.2

ctalledo added a commit that referenced this issue Aug 19, 2024
@ctalledo
Fix bug in kernel version comparison.
554776f 
Per #131.

Signed-off-by: Cesar Talledo <cesar.talledo@docker.com>
@ctalledo ctalledo mentioned this issue Aug 19, 2024
Merged
@ctalledo
Copy link
Member

ctalledo commented Aug 19, 2024 •
edited
Loading

Thanks @haseoleonard for catching that issue!

Fix PR: #132

rodnymolina pushed a commit that referenced this issue Oct 6, 2024
@ctalledo @rodnymolina
Fix bug in kernel version comparison.
78e9280 
Per #131.

Signed-off-by: Cesar Talledo <cesar.talledo@docker.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@haseoleonard @ctalledo