Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow @fastify/static v7 #13152

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

alexfriesen
Copy link
Contributor

This change allows updating @fastify/static to v7.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

when updating @fastify/static you might get the error "Conflicting peer dependency".

Issue Number: N/A

What is the new behavior?

allows updating @fastify/static

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

Pull Request Test Coverage Report for Build 81736f36-5a1e-4304-86a1-c8a83020906a

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.197%

Totals Coverage Status
Change from base Build 889ffab4-7a4b-4e81-8f8a-630e303f4274: 0.0%
Covered Lines: 6723
Relevant Lines: 7292

💛 - Coveralls

Copy link
Member

@micalevisk micalevisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v7 release notes

not sure why it's a major bump

@kamilmysliwiec kamilmysliwiec merged commit be76a35 into nestjs:master Feb 7, 2024
5 checks passed
@kamilmysliwiec
Copy link
Member

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants