Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose cache manager alias provider Cache class with same as the interface from cache-manager #256

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

micalevisk
Copy link
Member

@micalevisk micalevisk commented Dec 30, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: closes #253

What is the new behavior?

  1. no need to use @Inject(CACHE_MANAGER) anymore
  2. no need to import Cache from another package. Always use the @nestjs/cache-manager one

image

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kamilmysliwiec kamilmysliwiec merged commit 7a111a4 into nestjs:master Jan 8, 2024
@kamilmysliwiec
Copy link
Member

lgtm

@kamilmysliwiec kamilmysliwiec added the enhancement New feature or request label Jan 8, 2024
@micalevisk micalevisk deleted the feat/issue-253 branch January 8, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge injection token for cache and cache instance
2 participants