Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make instance property and makeObservable() method protected #348

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

mikeyaa
Copy link
Contributor

@mikeyaa mikeyaa commented Mar 5, 2022

Make instance property and makeObservable() method protected instead of private

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Currently instance and makeObservable() are marked private this makes it difficult to subclass the HttpService and add additional functionality.

Issue Number: N/A

What is the new behavior?

instance and makeObservable() are marked as protected so subclasses can utilize.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

make instance and makeObservable protected
@mikeyaa mikeyaa changed the title Update http.service.ts Make instance property and makeObservable() method protected Mar 5, 2022
@kamilmysliwiec
Copy link
Member

LGTM

@kamilmysliwiec kamilmysliwiec merged commit 7a41689 into nestjs:master Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants