Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(RPC): add RPC to clear verify queue #4609

Merged

Conversation

chenyukang
Copy link
Collaborator

What problem does this PR solve?

With the new verify queue in PR #4291, the verify-queue may contain a lot of transactions in the extreme scenario, similar as clear_tx_pool we need a RPC to clear it.

What is changed and how it works?

Add a RPC clear_tx_verify_queue in the txpool RPC module.

Related changes

  • PR to update owner/repo:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • Performance regression
  • Breaking backward compatibility

Release note

Title Only: Include only the PR title in the release note.

@chenyukang chenyukang requested a review from a team as a code owner August 24, 2024 03:28
@chenyukang chenyukang requested review from doitian and removed request for a team August 24, 2024 03:28
@@ -322,6 +322,33 @@ pub trait PoolRpc {
#[rpc(name = "clear_tx_pool")]
fn clear_tx_pool(&self) -> Result<()>;

/// Removes all transactions from the verification queue.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// Removes all transactions from the verification queue.
/// Remove all transactions from the verification queue.

@chenyukang chenyukang added this pull request to the merge queue Aug 26, 2024
Merged via the queue into nervosnetwork:develop with commit 6ee85c3 Aug 26, 2024
34 checks passed
@eval-exec eval-exec changed the title chore(RPC): add PRC to clear verify queue chore(RPC): add RPC to clear verify queue Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants