Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SendLargeCyclesTxToRelay spec on slow machine #4606

Merged

Conversation

chenyukang
Copy link
Collaborator

What problem does this PR solve?

Fix the failure on MacOs Github CI.

What is changed and how it works?

The root cause is on slow machine, like Github MacOS CI server, it will cost almost 8 seconds to finish IBD stage, in spec SendLargeCyclesTxToRelay when the relay message is sent from node1 to node0, node0 may still in IBD mode, so tx is not synced.

Related changes

  • PR to update owner/repo:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Release note

None: Exclude this PR from the release note.

@chenyukang chenyukang requested a review from a team as a code owner August 22, 2024 10:41
@chenyukang chenyukang requested review from zhangsoledad and removed request for a team August 22, 2024 10:41
@chenyukang chenyukang added this pull request to the merge queue Aug 22, 2024
Merged via the queue into nervosnetwork:develop with commit 0ceb6f8 Aug 22, 2024
32 checks passed
@doitian doitian mentioned this pull request Aug 28, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants