Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add verify log for monitor #4600

Merged
merged 1 commit into from
Aug 23, 2024
Merged

chore: add verify log for monitor #4600

merged 1 commit into from
Aug 23, 2024

Conversation

chenyukang
Copy link
Collaborator

@chenyukang chenyukang commented Aug 20, 2024 •
edited
Loading

What problem does this PR solve?

We need more logs for monitoring abnormal behaviors.

What is changed and how it works?

Add info logs for verification failures.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Release note 

None: Exclude this PR from the release note.

@chenyukang chenyukang requested a review from a team as a code owner August 20, 2024 03:44
@chenyukang chenyukang requested review from quake and removed request for a team August 20, 2024 03:44
@doitian doitian added this pull request to the merge queue Aug 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 20, 2024
@doitian doitian added this pull request to the merge queue Aug 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 21, 2024
@chenyukang chenyukang added this pull request to the merge queue Aug 23, 2024
Merged via the queue into nervosnetwork:develop with commit 3bd5fed Aug 23, 2024
32 checks passed
@chenyukang chenyukang mentioned this pull request Aug 27, 2024
Closed
@doitian doitian mentioned this pull request Aug 28, 2024
Closed
3 tasks
@chenyukang chenyukang mentioned this pull request Sep 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doitian doitian doitian approved these changes

@quake quake Awaiting requested review from quake quake is a code owner automatically assigned from nervosnetwork/ckb-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenyukang @doitian