Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit test and integration test for test_accept_block and SyncChurn #4563

Merged
merged 4 commits into from
Aug 5, 2024

Conversation

eval-exec
Copy link
Collaborator

@eval-exec eval-exec commented Aug 4, 2024

What problem does this PR solve?

Fix unit test and integration test on latest develop branch CI.

What is changed and how it works?

What's Changed:

Related changes

  • Wait init_load_unverified thread exit before processing block in unit test
  • Don't use unwrap on SyncChurn's Sender'
  • Wait rpc_client are ready before send rpc request

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note

None: Exclude this PR from the release note.

@eval-exec eval-exec requested a review from a team as a code owner August 4, 2024 00:12
@eval-exec eval-exec requested review from doitian and chenyukang and removed request for a team August 4, 2024 00:12
@eval-exec eval-exec added the t:ci Type: CI label Aug 4, 2024
zhangsoledad
zhangsoledad previously approved these changes Aug 4, 2024
@chenyukang chenyukang added this pull request to the merge queue Aug 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 4, 2024
…nerate block

Signed-off-by: Eval EXEC <execvy@gmail.com>
@eval-exec eval-exec requested a review from driftluo August 4, 2024 16:32
@eval-exec eval-exec added the t:test: Integration Test Type: This issue is related to test. label Aug 4, 2024
@eval-exec eval-exec self-assigned this Aug 4, 2024
doitian
doitian previously approved these changes Aug 5, 2024
@doitian doitian added this pull request to the merge queue Aug 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 5, 2024
@quake quake added this pull request to the merge queue Aug 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 5, 2024
@eval-exec
Copy link
Collaborator Author

make security-audit failed, investigating....

@eval-exec
Copy link
Collaborator Author

eval-exec commented Aug 5, 2024

cargo deny check --hide-inclusion-graph --show-stats advisories sources
error[deprecated]: this key has been removed, see https://github.com/EmbarkStudios/cargo-deny/pull/611 for migration information
  ┌─ /home/runner/work/ckb/ckb/deny.toml:2:1
  
2 │ vulnerability = "deny"
  │ ━━━━━━━━━━━━━

error[deprecated]: this key has been removed, see https://github.com/EmbarkStudios/cargo-deny/pull/611 for migration information
  ┌─ /home/runner/work/ckb/ckb/deny.toml:3:1
  
3 │ unmaintained = "warn"
  │ ━━━━━━━━━━━━

error[deprecated]: this key has been removed, see https://github.com/EmbarkStudios/cargo-deny/pull/611 for migration information
  ┌─ /home/runner/work/ckb/ckb/deny.toml:5:1
  
5 │ notice = "deny"
  │ ━━━━━━

deny.toml format is outdated, get the new deny.toml by cargo deny init.

@eval-exec
Copy link
Collaborator Author

@quake Request for review and re-added this PR to merge queue.

Signed-off-by: Eval EXEC <execvy@gmail.com>
@doitian doitian added this pull request to the merge queue Aug 5, 2024
Merged via the queue into nervosnetwork:develop with commit 4e9e086 Aug 5, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:ci Type: CI t:test: Integration Test Type: This issue is related to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants