Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #4447 's 2nd commit,Remove unreachable error for test_tx_pool_accept #4449

Merged
merged 1 commit into from
May 10, 2024
Merged

Backport #4447 's 2nd commit,Remove unreachable error for test_tx_pool_accept #4449

merged 1 commit into from
May 10, 2024

Conversation

eval-exec
Copy link
Collaborator

Backport #4447 's second commit.

What problem does this PR solve?

Related changes

  • Remove unreachable errors for test_tx_pool_accept

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • Performance regression
  • Breaking backward compatibility

Release note 

None: Exclude this PR from the release note.

@eval-exec eval-exec requested a review from a team as a code owner May 6, 2024 04:38
@eval-exec eval-exec requested review from quake and doitian May 6, 2024 04:38
@zhangsoledad zhangsoledad merged commit 200c783 into nervosnetwork:rc/v0.116.x May 10, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangsoledad zhangsoledad zhangsoledad approved these changes

@quake quake Awaiting requested review from quake quake is a code owner automatically assigned from nervosnetwork/ckb-dev

@doitian doitian Awaiting requested review from doitian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eval-exec @zhangsoledad