Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix windows integration test compile error #4424

Merged
merged 3 commits into from
Apr 22, 2024
Merged

Fix windows integration test compile error #4424

merged 3 commits into from
Apr 22, 2024

Conversation

eval-exec
Copy link
Collaborator

@eval-exec eval-exec commented Apr 21, 2024 •
edited
Loading

What problem does this PR solve?

In the latest develop branch's CI report: https://github.com/nervosnetwork/ckb/actions/runs/8749973042/job/24047547692
ckb-test compile error

What is changed and how it works?

Related changes

  • fix ckb-test compile error

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note 

None: Exclude this PR from the release note.

@eval-exec eval-exec requested a review from a team as a code owner April 21, 2024 11:38
@eval-exec eval-exec requested review from doitian and removed request for a team April 21, 2024 11:38
quake
quake reviewed Apr 21, 2024
View reviewed changes
test/src/node.rs Outdated Show resolved Hide resolved
@eval-exec eval-exec requested a review from quake April 21, 2024 12:31
@eval-exec eval-exec added this pull request to the merge queue Apr 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 22, 2024
@zhangsoledad zhangsoledad added this pull request to the merge queue Apr 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 22, 2024
@eval-exec
Copy link
Collaborator Author

Rebased just now.

@eval-exec eval-exec added this pull request to the merge queue Apr 22, 2024
Merged via the queue into nervosnetwork:develop with commit 282872c Apr 22, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doitian doitian doitian approved these changes

@quake quake Awaiting requested review from quake

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eval-exec @quake @doitian