Save BlockView
after non_contextual_verify
, Remove ConsumeOrphan
thread, Preload UnverifiedBlock
for ConsumeUnverified
thread.
#4391
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Want to merge into #4365
This PR mainly aims to have the
ChainService
store the block into the db as soon as it receives it and completes thenon_contextual_verify
. This way, theOrphanBroker
only saves the smaller-sizedLonelyBlockHash
in memory. Additionally, aPreloadUnverified
thread is added to preloadUnverifiedBlocks
from the db, which are then consumed by theConsumeUnverified
thread.The advantage of this approach is that even when syncing large blocks during moments like the Omiga, the memory usage of CKB will not significantly increase.
What's Changed:
Related changes
BlockView
to db afternon_contextual_verify
ConsumeOrphan
thread, letOrphanBroker
only recordLonelyBlockHash
in memoryPreloadUnverifiedBlock
to pre-loadUnverifiedBlock
forConsumeUnverified
thread.Check List
Tests
Side effects
Release note