Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dev chain): Adjusting the default dev chain epoch parameter #4366

Merged
merged 2 commits into from
Apr 7, 2024

Conversation

EthanYuan
Copy link
Collaborator

@EthanYuan EthanYuan commented Mar 1, 2024

What problem does this PR solve?

Problem Summary:

For dev chain, we often expect faster epoch advancement to facilitate testing. The previous default value was set a bit large, and to make it so that it doesn't need to be manually adjusted every time, a smaller value was set.

What is changed and how it works?

What's Changed:

The following modification keeps the epoch length at 10:

epoch_duration_target = 80
genesis_epoch_length = 10

Check List

Tests

  • Manual test

Side effects

  • Breaking backward compatibility

Release note

Title Only: Include only the PR title in the release note.

@EthanYuan EthanYuan force-pushed the edit-dev-chain-default-epoch branch from adc0488 to 7999e14 Compare March 13, 2024 15:11
@EthanYuan EthanYuan marked this pull request as ready for review March 13, 2024 15:13
@EthanYuan EthanYuan requested a review from a team as a code owner March 13, 2024 15:13
@zhangsoledad zhangsoledad added this pull request to the merge queue Mar 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 14, 2024
@quake quake added this pull request to the merge queue Apr 7, 2024
Merged via the queue into nervosnetwork:develop with commit 9078a11 Apr 7, 2024
33 checks passed
@doitian doitian mentioned this pull request Apr 23, 2024
@EthanYuan EthanYuan deleted the edit-dev-chain-default-epoch branch July 11, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🥳 Released
Development

Successfully merging this pull request may close these issues.

4 participants