Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport 114: A peer send malformed tx with large cycles will also be banned #4349

Conversation

chenyukang
Copy link
Collaborator

@chenyukang chenyukang commented Feb 9, 2024

What problem does this PR solve?

There is a copy-paste bug in resumeble_process_tx, when a peer send malformed_tx with large cycles it won't be banned for a while.

What is changed and how it works?

Fix the parameter error in invoking non_contextual_verify.

What's Changed:

Related changes

  • PR to update owner/repo:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • Performance regression
  • Breaking backward compatibility

Release note

Title Only: Include only the PR title in the release note.

@chenyukang chenyukang requested a review from a team as a code owner February 9, 2024 03:31
@quake quake merged commit 3846d45 into nervosnetwork:rc/v0.114.x Feb 9, 2024
33 checks passed
@z1617
Copy link

z1617 commented Mar 7, 2024

Please check typo.

@chenyukang chenyukang changed the title backport 114: A peer send manlformed tx with large cycles will also be banned backport 114: A peer send malformed tx with large cycles will also be banned Mar 7, 2024
@chenyukang
Copy link
Collaborator Author

Please check typo.

Fixed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants