Move some helper function for building blocks/txs from ckb-chain to ckb-test-chain-utils
#4335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eval EXEC <execvy@gmail.com>
driftluo
approved these changes
Feb 1, 2024
quake
approved these changes
Feb 1, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
In issue #4333, I encountered a need to generate blocks for the unit tests of the
ckb-relayermodules. To achieve this, I would like to utilize certain helper functions from theckb-chaincodebase. Therefore, I have decided to relocate these helper functions fromckb-chaintockb-test-chain-utilsso thatckb-relayercan make use of them for its unit tests.What's Changed:
Related changes
chain/src/tests/util.rsto./util/test-chain-utilsCheck List
Tests
Side effects
Release note