Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove boto3 #1743

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Remove boto3 #1743

merged 3 commits into from
Apr 16, 2024

Conversation

AleksanderWWW
Copy link
Contributor

@AleksanderWWW AleksanderWWW commented Apr 15, 2024

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you ask the docs owner to review all the user-facing changes?

@AleksanderWWW
Copy link
Contributor Author

AleksanderWWW commented Apr 15, 2024

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 77.28%. Comparing base (5595eb7) to head (2e9e2b2).

Files Patch % Lines
src/neptune/internal/artifacts/drivers/s3.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1743      +/-   ##
==========================================
- Coverage   77.58%   77.28%   -0.30%     
==========================================
  Files         243      243              
  Lines       12946    12947       +1     
==========================================
- Hits        10044    10006      -38     
- Misses       2902     2941      +39     
Flag Coverage Δ
e2e 65.96% <33.33%> (-0.08%) ⬇️
e2e-management 55.86% <0.00%> (-0.02%) ⬇️
e2e-s3 53.02% <33.33%> (-0.08%) ⬇️
e2e-s3-gcs 53.02% <33.33%> (-0.08%) ⬇️
e2e-standard 65.94% <0.00%> (-0.08%) ⬇️
macos 77.15% <33.33%> (-0.35%) ⬇️
py3.10 ?
py3.11 ?
py3.12 66.00% <33.33%> (-11.76%) ⬇️
py3.7 76.66% <33.33%> (-0.23%) ⬇️
py3.7.16 65.06% <33.33%> (-11.72%) ⬇️
py3.8 ?
py3.9 ?
ubuntu 77.19% <33.33%> (-0.30%) ⬇️
unit 73.20% <0.00%> (-0.91%) ⬇️
windows 76.86% <33.33%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AleksanderWWW
Copy link
Contributor Author

@AleksanderWWW AleksanderWWW merged commit 15dbd1e into master Apr 16, 2024
29 checks passed
@AleksanderWWW AleksanderWWW deleted the aw/remove-boto branch April 16, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants