Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable file logging #1733

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Disable file logging #1733

merged 2 commits into from
Apr 17, 2024

Conversation

szysad
Copy link
Contributor

@szysad szysad commented Apr 10, 2024

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you ask the docs owner to review all the user-facing changes?

@szysad
Copy link
Contributor Author

szysad commented Apr 10, 2024

E2E

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.30%. Comparing base (1de1f64) to head (9d7996e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1733      +/-   ##
==========================================
- Coverage   75.32%   72.30%   -3.02%     
==========================================
  Files         244      244              
  Lines       13036    12833     -203     
==========================================
- Hits         9819     9279     -540     
- Misses       3217     3554     +337     
Flag Coverage Δ
e2e ?
e2e-management ?
e2e-s3 ?
e2e-s3-gcs ?
e2e-standard ?
macos 72.18% <100.00%> (-3.08%) ⬇️
py3.10 ?
py3.11 ?
py3.12 ?
py3.7 72.30% <100.00%> (-2.34%) ⬇️
py3.7.16 ?
py3.8 ?
py3.9 ?
ubuntu 72.25% <100.00%> (-3.01%) ⬇️
unit 72.30% <100.00%> (-0.73%) ⬇️
windows 70.99% <100.00%> (-2.89%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szysad
Copy link
Contributor Author

szysad commented Apr 16, 2024

E2E

@szysad szysad marked this pull request as ready for review April 16, 2024 14:24
@szysad szysad merged commit dc3217b into master Apr 17, 2024
4 checks passed
@szysad szysad deleted the ss/disable-logging-files branch April 17, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants